Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9650 list the linked dataverse in the link edit form #9661

Conversation

pkiraly
Copy link
Member

@pkiraly pkiraly commented Jun 19, 2023

What this PR does / why we need it:

With this changes the user can see the list of linked dataverses at the dataset page's link edit form.

Which issue(s) this PR closes:

It is one step towards #9650

Special notes for your reviewer:

It contains a UI change, but I am not an expert of Dataverse's stylesheet classes. I have created some rough direct formatting via the "style" attribute of HTML elements. A UI expert might give suggestions how to improve it.

Suggestions on how to test this:

  1. run mvn clean package and deploy the war file to the test environment
  2. if you do not have a dataset which is already linked to a dataverse, create a link
  3. open the "Link Dataset" form at the dataset page, and check what is below the "Save Linked Dataset" button

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Here you can find the result:
Screenshot from 2023-06-19 23-15-07

Is there a release notes update needed for this change?:
It might worth to mention it that the user now can list the linked dataverses from the dataset page as well.

Additional documentation:

@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Feb 28, 2024
@scolapasta
Copy link
Contributor

If you are still interested in this PR, can you please merge and resolve any merge conflicts with the latest from develop? If so, we can prioritize reviewing and QAing the changes. If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest).

@cmbz cmbz added UX/UI Input Needed Apply to issues involving UX or UI implications that need additional input Status: Needs Input Applied to issues in need of input from someone currently unavailable and removed UX/UI Input Needed Apply to issues involving UX or UI implications that need additional input labels Apr 29, 2024
@cmbz
Copy link

cmbz commented Apr 29, 2024

Awaiting author reply

@pdurbin
Copy link
Member

pdurbin commented May 23, 2024

If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest).

Closing.

@pdurbin pdurbin closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours. Status: Needs Input Applied to issues in need of input from someone currently unavailable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants